-
-
Notifications
You must be signed in to change notification settings - Fork 187
fix: add polyfills / avoid using structuredClone
#915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I don't want to touch core-js with a bargepole. This is the effect of those two imports on the bundle size:
Let's find another approach, whether that's writing our own polyfill or avoiding those features |
- polyfills for `at` and `withResolvers` - avoid using `structuredClone`, we can use `JSON.parse(JSON.stringify(..))` instead at that position makes the site work in more browsers closes #911
wow, that's bad - I created our own polyfills instead |
Can you let me know when this is deployed to the site, so that I can test it for you? |
It's deployed already |
Well that's odd. I only have 17.6 installed here but it works fine. Both places that use |
I did a hard refresh, so I don't know? CloudFlare maybe? |
The Polyfill for Array.prototype.at does not handle |
at
andwithResolvers
structuredClone
, we can useJSON.parse(JSON.stringify(..))
instead at that positionmakes the site work in more browsers
closes #911 assuming we're fine with not supporting Safari 13 and lower (or similarly old browsers; i.e. earlier than ~2020)